-
Notifications
You must be signed in to change notification settings - Fork 10
69 support for azure blob storage #261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ling; remove unnecessary semicolons.
…zureAttachmentsService
eric-pSAP
approved these changes
Oct 10, 2025
…ureAttachmentsService
This pr: - changes the attachment tests so they aren't dependent on one another - added a clearing of the attachments before and after each test - added helper functions to reduce redundant code - documented these helper functions if they are ever needed again Closes: #258 --------- Co-authored-by: Marten Schiwek <marten.schiwek@sap.com> Co-authored-by: Simon Kobler <32038731+KoblerS@users.noreply.github.com>
…ove error handling in various methods
Adjust collection name for working i18n integration.
Needed for translation workbench
…#270) - Refactor content handling in AWSAttachmentsService to ensure cleanup after uploads. - Improve error handling in malwareScanner by streaming files directly to the scanner. - Optimize memory usage in basic.js and plugin.js by clearing content references post-upload.
…ved clarity and error handling
cd90333 to
1be239e
Compare
1be239e to
80ea57e
Compare
…Blob Storage services
eric-pSAP
approved these changes
Oct 20, 2025
…ethods and streamline draft update handlers
This pull request addresses a bug where attachments were not deleted from AWS due to incorrect entity path resolution. The fix adds support for both `.attachments` and `_attachments` suffixes. Note: this is a temporary fix and I suggest to find another solution instead of hardcoding the children entities by the name, --------- Co-authored-by: Vinicius Lora <vinicius.lora@sap.com> Co-authored-by: Eric Peairs <eric.peairs@sap.com> Co-authored-by: Simon Kobler <simon.kobler@sap.com> Co-authored-by: Simon Kobler <32038731+KoblerS@users.noreply.github.com> Co-authored-by: Marten Schiwek <marten.schiwek@sap.com>
Remove the xmpl folder and not working sample in favour of one sample in the tests folder. Adjusts Readme and Contributing.md to point to this sample.
This is meant to add more information as well as clarify current information. Also want to align with the [README of the Java version of Attachments](https://github.com/cap-java/cds-feature-attachments/blob/main/README.md). Steps remaining: - [x] Finalize structure and sections - [x] Removing Java-specific sections and information - [x] Confirm and clarify details - [x] Add in links to sources This initial change should make the rest of the editing process more streamlined --------- Co-authored-by: Simon Kobler <32038731+KoblerS@users.noreply.github.com> Co-authored-by: Lisa Julia Nebel <lisajuliafog@yahoo.de> Co-authored-by: René Jeglinsky <rene.jeglinsky@sap.com> Co-authored-by: Simon Kobler <simon.kobler@sap.com>
schiwekM
reviewed
Oct 27, 2025
de7d1f9 to
d126135
Compare
…ctionality for Azure Blob objects
d126135 to
ff2fa09
Compare
schiwekM
reviewed
Oct 28, 2025
ef77012 to
a4cd73f
Compare
schiwekM
requested changes
Oct 28, 2025
Co-authored-by: Marten Schiwek <marten.schiwek@sap.com>
d67ea64 to
8e5413e
Compare
…ing validation logic and removing redundant service manager checks
8e5413e to
a172f93
Compare
schiwekM
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to #69