Skip to content

Conversation

@KoblerS
Copy link
Collaborator

@KoblerS KoblerS commented Oct 10, 2025

Link to #69

@KoblerS KoblerS requested review from eric-pSAP and schiwekM October 10, 2025 09:10
@KoblerS KoblerS self-assigned this Oct 10, 2025
@KoblerS KoblerS added the enhancement New feature or request label Oct 10, 2025
@KoblerS KoblerS marked this pull request as ready for review October 10, 2025 10:34
KoblerS and others added 8 commits October 16, 2025 12:29
This pr:
- changes the attachment tests so they aren't dependent on one another
- added a clearing of the attachments before and after each test
- added helper functions to reduce redundant code
- documented these helper functions if they are ever needed again

Closes: #258

---------

Co-authored-by: Marten Schiwek <marten.schiwek@sap.com>
Co-authored-by: Simon Kobler <32038731+KoblerS@users.noreply.github.com>
Adjust collection name for working i18n integration.
Needed for translation workbench
…#270)

- Refactor content handling in AWSAttachmentsService to ensure cleanup
after uploads.
- Improve error handling in malwareScanner by streaming files directly
to the scanner.
- Optimize memory usage in basic.js and plugin.js by clearing content
references post-upload.
@KoblerS KoblerS force-pushed the 69-support-for-azure-blob-storage branch from cd90333 to 1be239e Compare October 16, 2025 11:54
@KoblerS KoblerS force-pushed the 69-support-for-azure-blob-storage branch from 1be239e to 80ea57e Compare October 16, 2025 11:55
@KoblerS KoblerS requested a review from a team as a code owner October 20, 2025 07:22
vlovini and others added 6 commits October 27, 2025 14:49
This pull request addresses a bug where attachments were not deleted
from AWS due to incorrect entity path resolution. The fix adds support
for both `.attachments` and `_attachments` suffixes.

Note: this is a temporary fix and I suggest to find another solution
instead of hardcoding the children entities by the name,

---------

Co-authored-by: Vinicius Lora <vinicius.lora@sap.com>
Co-authored-by: Eric Peairs <eric.peairs@sap.com>
Co-authored-by: Simon Kobler <simon.kobler@sap.com>
Co-authored-by: Simon Kobler <32038731+KoblerS@users.noreply.github.com>
Co-authored-by: Marten Schiwek <marten.schiwek@sap.com>
Remove the xmpl folder and not working sample in favour of one sample in
the tests folder.

Adjusts Readme and Contributing.md to point to this sample.
This is meant to add more information as well as clarify current
information. Also want to align with the [README of the Java version of
Attachments](https://github.com/cap-java/cds-feature-attachments/blob/main/README.md).
Steps remaining:
- [x] Finalize structure and sections 
   - [x] Removing Java-specific sections and information
- [x] Confirm and clarify details
- [x] Add in links to sources


This initial change should make the rest of the editing process more
streamlined

---------

Co-authored-by: Simon Kobler <32038731+KoblerS@users.noreply.github.com>
Co-authored-by: Lisa Julia Nebel <lisajuliafog@yahoo.de>
Co-authored-by: René Jeglinsky <rene.jeglinsky@sap.com>
Co-authored-by: Simon Kobler <simon.kobler@sap.com>
@KoblerS KoblerS requested a review from schiwekM October 28, 2025 10:06
@KoblerS KoblerS force-pushed the 69-support-for-azure-blob-storage branch from de7d1f9 to d126135 Compare October 28, 2025 10:06
@KoblerS KoblerS force-pushed the 69-support-for-azure-blob-storage branch from d126135 to ff2fa09 Compare October 28, 2025 10:07
@KoblerS KoblerS requested a review from schiwekM October 28, 2025 11:52
@KoblerS KoblerS force-pushed the 69-support-for-azure-blob-storage branch from ef77012 to a4cd73f Compare October 28, 2025 12:13
@KoblerS KoblerS force-pushed the 69-support-for-azure-blob-storage branch 2 times, most recently from d67ea64 to 8e5413e Compare October 28, 2025 15:04
…ing validation logic and removing redundant service manager checks
@KoblerS KoblerS force-pushed the 69-support-for-azure-blob-storage branch from 8e5413e to a172f93 Compare October 28, 2025 15:18
@KoblerS KoblerS requested a review from schiwekM October 28, 2025 15:27
@schiwekM schiwekM merged commit 6987f54 into main Oct 29, 2025
7 checks passed
@schiwekM schiwekM deleted the 69-support-for-azure-blob-storage branch October 29, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants